Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: Source/web/tests/TopControlsTest.cpp

Issue 1174283002: Fix unit test style in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove static Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/TextFinderTest.cpp ('k') | Source/web/tests/TouchActionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/TopControlsTest.cpp
diff --git a/Source/web/tests/TopControlsTest.cpp b/Source/web/tests/TopControlsTest.cpp
index 7a240ad407b1961e84d6b03bb41ae64db40a21db..73630e65571bd89bc4a0b356dc6af4502e9e81e5 100644
--- a/Source/web/tests/TopControlsTest.cpp
+++ b/Source/web/tests/TopControlsTest.cpp
@@ -40,13 +40,10 @@
#include "public/web/WebSettings.h"
#include "web/WebLocalFrameImpl.h"
#include "web/tests/FrameTestHelpers.h"
-
#include <gmock/gmock.h>
#include <gtest/gtest.h>
-using namespace blink;
-
-namespace {
+namespace blink {
// These tests cover top controls scrolling on main-thread.
// The animation for completing a partial show/hide is done in compositor so
@@ -62,7 +59,7 @@ public:
registerMockedHttpURLLoad("iframe-scrolling-inner.html");
}
- ~TopControlsTest()
+ ~TopControlsTest() override
{
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
}
@@ -552,4 +549,4 @@ TEST_F(TopControlsTest, MAYBE(StateConstraints))
EXPECT_POINT_EQ(IntPoint(0, 90), frame()->view()->scrollPosition());
}
-} // namespace
+} // namespace blink
« no previous file with comments | « Source/web/tests/TextFinderTest.cpp ('k') | Source/web/tests/TouchActionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698