Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1174283002: Fix unit test style in Source/web/. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix unit test style in Source/web/. Mainly fix namespace usage. BUG=498604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196928

Patch Set 1 : #

Total comments: 6

Patch Set 2 : remove static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -287 lines) Patch
M Source/platform/scroll/ScrollAnimatorNone.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/AssociatedURLLoaderTest.cpp View 9 chunks +14 lines, -16 lines 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 4 chunks +29 lines, -30 lines 0 comments Download
M Source/web/WebNodeTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/web/tests/ChromeClientImplTest.cpp View 6 chunks +8 lines, -10 lines 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/web/tests/ImeOnFocusTest.cpp View 5 chunks +9 lines, -11 lines 0 comments Download
M Source/web/tests/KeyboardTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/web/tests/LayoutGeometryMapTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/web/tests/LinkHighlightTest.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M Source/web/tests/ListenerLeakTest.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M Source/web/tests/MHTMLTest.cpp View 5 chunks +5 lines, -11 lines 0 comments Download
M Source/web/tests/OpenTypeVerticalDataTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/tests/PageSerializerTest.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/web/tests/ProgrammaticScrollTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorTest.cpp View 4 chunks +3 lines, -6 lines 0 comments Download
M Source/web/tests/SpinLockTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 8 chunks +16 lines, -18 lines 0 comments Download
M Source/web/tests/TopControlsTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/web/tests/WebDocumentTest.cpp View 1 4 chunks +32 lines, -32 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 6 chunks +7 lines, -4 lines 0 comments Download
M Source/web/tests/WebImageTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M Source/web/tests/WebPageSerializerTest.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 4 chunks +12 lines, -11 lines 0 comments Download
M Source/web/tests/WebScopedWindowFocusAllowedIndicatorTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/tests/WebSearchableFormDataTest.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M Source/web/tests/WebSelectorTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/tests/WebURLRequestTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/web/tests/WebURLResponseTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/web/tests/WebUserGestureTokenTest.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 7 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
kochi-san, would you take a look at this please? Low priority.
4 years, 10 months ago (2015-06-11 06:32:44 UTC) #8
kochi
lgtm with nits. https://codereview.chromium.org/1174283002/diff/120001/Source/web/tests/WebDocumentTest.cpp File Source/web/tests/WebDocumentTest.cpp (right): https://codereview.chromium.org/1174283002/diff/120001/Source/web/tests/WebDocumentTest.cpp#newcode154 Source/web/tests/WebDocumentTest.cpp:154: static KURL toOriginA(const char* file) nit: ...
4 years, 10 months ago (2015-06-11 07:34:50 UTC) #9
tkent
https://codereview.chromium.org/1174283002/diff/120001/Source/web/tests/WebDocumentTest.cpp File Source/web/tests/WebDocumentTest.cpp (right): https://codereview.chromium.org/1174283002/diff/120001/Source/web/tests/WebDocumentTest.cpp#newcode154 Source/web/tests/WebDocumentTest.cpp:154: static KURL toOriginA(const char* file) On 2015/06/11 07:34:50, Takayoshi ...
4 years, 10 months ago (2015-06-11 07:38:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174283002/140001
4 years, 10 months ago (2015-06-11 07:38:51 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 08:48:13 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196928

Powered by Google App Engine
This is Rietveld 408576698