Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(92)

Issue 1174243004: Remove CSSStyleDeclaration::copyProperties() (Closed)

Created:
4 years, 10 months ago by Timothy Loh
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove CSSStyleDeclaration::copyProperties() The virtual CSSStyleDeclaration::copyProperties is never called, while copyProperties on CSSComputedStyleDeclaration is used from editing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
4 years, 10 months ago (2015-06-12 06:09:59 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 10 months ago (2015-06-12 06:11:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174243004/1
4 years, 10 months ago (2015-06-12 06:11:31 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 07:31:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197010

Powered by Google App Engine
This is Rietveld 408576698