Issue 1174243004: Remove CSSStyleDeclaration::copyProperties()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174243004: Remove CSSStyleDeclaration::copyProperties() (Closed)

Created:
4 years, 10 months ago by Timothy Loh

Modified:
4 years, 10 months ago

Reviewers:
alancutter (OOO until 2018)

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove CSSStyleDeclaration::copyProperties() The virtual CSSStyleDeclaration::copyProperties is never called, while copyProperties on CSSComputedStyleDeclaration is used from editing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197010

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -9 lines)			Patch
M	Source/core/css/CSSComputedStyleDeclaration.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/PropertySetCSSStyleDeclaration.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/PropertySetCSSStyleDeclaration.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174243004/1

4 years, 10 months ago (2015-06-12 06:11:31 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-12 07:31:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197010

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages