Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1174223006: DevTools: Adjust bad frames color on timeline flamechart. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelineFrameModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index de2e390c6673a0d90b0b987872b92d9d4f7eba60..02d5ed5c0e202cadec7abbaa601af3c543d120fb 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -574,22 +574,15 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
var frame = this._entryIndexToFrame[entryIndex];
if (frame) {
var /** @const */ vPadding = 1;
- var /** @const */ hPadding = 2;
+ var /** @const */ hPadding = 1;
barX += hPadding;
barWidth -= 2 * hPadding;
barY += vPadding;
barHeight -= 2 * vPadding + 1;
- context.fillStyle = frame.idle ? "#eee" : "#ccc";
+ context.fillStyle = frame.hasWarnings() ? "hsl(0, 80%, 70%)" : "white";
context.fillRect(barX, barY, barWidth, barHeight);
- // Draw frame perforation.
- context.fillStyle = "white";
yurys 2015/06/17 13:16:29 Please note this in the description.
alph 2015/06/17 13:23:18 Done.
- for (var i = 1; i < barWidth; i += 4) {
- context.fillRect(barX + i, barY + 1, 2, 2);
- context.fillRect(barX + i, barY + barHeight - 3, 2, 2);
- }
-
var frameDurationText = Number.preciseMillisToString(frame.duration, 1);
var textWidth = context.measureText(frameDurationText).width;
if (barWidth > textWidth) {
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelineFrameModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698