Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1174223006: DevTools: Adjust bad frames color on timeline flamechart. (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
caseq, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Adjust bad frames color on timeline flamechart. + nuke frames perforation decoration. BUG=501309 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197266

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +2 lines, -9 lines 2 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alph
4 years, 10 months ago (2015-06-17 13:14:48 UTC) #2
yurys
lgtm https://codereview.chromium.org/1174223006/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (left): https://codereview.chromium.org/1174223006/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#oldcode587 Source/devtools/front_end/timeline/TimelineFlameChart.js:587: context.fillStyle = "white"; Please note this in the ...
4 years, 10 months ago (2015-06-17 13:16:29 UTC) #3
alph
https://codereview.chromium.org/1174223006/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (left): https://codereview.chromium.org/1174223006/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#oldcode587 Source/devtools/front_end/timeline/TimelineFlameChart.js:587: context.fillStyle = "white"; On 2015/06/17 13:16:29, yurys wrote: > ...
4 years, 10 months ago (2015-06-17 13:23:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174223006/1
4 years, 10 months ago (2015-06-17 13:23:51 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 15:20:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197266

Powered by Google App Engine
This is Rietveld 408576698