Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2496)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/profiles/profile_shortcut_manager_win.cc

Issue 11742007: Add support for adding 256x256 pngs to Windows .ico files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/jumplist_win.cc ('k') | chrome/browser/web_applications/web_app_win.cc » ('j') | ui/gfx/icon_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_shortcut_manager_win.cc
===================================================================
--- chrome/browser/profiles/profile_shortcut_manager_win.cc (revision 174803)
+++ chrome/browser/profiles/profile_shortcut_manager_win.cc (working copy)
@@ -92,7 +92,9 @@
// Finally, write the .ico file containing this new bitmap.
const FilePath icon_path =
profile_path.AppendASCII(profiles::internal::kProfileIconFileName);
- if (!IconUtil::CreateIconFileFromSkBitmap(final_bitmap, icon_path))
+ // TODO(asvitkine): Create icon with a large 256x256 bitmap.
+ if (!IconUtil::CreateIconFileFromSkBitmap(final_bitmap, SkBitmap(),
+ icon_path))
return FilePath();
return icon_path;
« no previous file with comments | « chrome/browser/jumplist_win.cc ('k') | chrome/browser/web_applications/web_app_win.cc » ('j') | ui/gfx/icon_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698