Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4223)

Unified Diff: chrome/browser/themes/theme_syncable_service_unittest.cc

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/themes/theme_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_app_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_syncable_service_unittest.cc
diff --git a/chrome/browser/themes/theme_syncable_service_unittest.cc b/chrome/browser/themes/theme_syncable_service_unittest.cc
index e82369aa1cbd5b2de6d10989f0bf5191be96ba78..8be578f5391124a24c79eda839760e6753431145 100644
--- a/chrome/browser/themes/theme_syncable_service_unittest.cc
+++ b/chrome/browser/themes/theme_syncable_service_unittest.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
+#include "chrome/common/extensions/api/extension_urls/extension_urls_handler.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/test/base/testing_profile.h"
@@ -353,7 +354,7 @@ TEST_F(ThemeSyncableServiceTest, UpdateThemeSpecificsFromCurrentTheme) {
EXPECT_TRUE(theme_specifics.use_custom_theme());
EXPECT_EQ(theme_extension_->id(), theme_specifics.custom_theme_id());
EXPECT_EQ(theme_extension_->name(), theme_specifics.custom_theme_name());
- EXPECT_EQ(theme_extension_->update_url().spec(),
+ EXPECT_EQ(extensions::ExtensionURL::GetUpdateURL(theme_extension_).spec(),
theme_specifics.custom_theme_update_url());
}
@@ -370,7 +371,7 @@ TEST_F(ThemeSyncableServiceTest, GetAllSyncData) {
EXPECT_TRUE(theme_specifics.use_custom_theme());
EXPECT_EQ(theme_extension_->id(), theme_specifics.custom_theme_id());
EXPECT_EQ(theme_extension_->name(), theme_specifics.custom_theme_name());
- EXPECT_EQ(theme_extension_->update_url().spec(),
+ EXPECT_EQ(extensions::ExtensionURL::GetUpdateURL(theme_extension_).spec(),
theme_specifics.custom_theme_update_url());
}
@@ -433,7 +434,7 @@ TEST_F(ThemeSyncableServiceTest, OnThemeChangeByUser) {
EXPECT_TRUE(change_specifics.use_custom_theme());
EXPECT_EQ(theme_extension_->id(), change_specifics.custom_theme_id());
EXPECT_EQ(theme_extension_->name(), change_specifics.custom_theme_name());
- EXPECT_EQ(theme_extension_->update_url().spec(),
+ EXPECT_EQ(extensions::ExtensionURL::GetUpdateURL(theme_extension_).spec(),
change_specifics.custom_theme_update_url());
}
« no previous file with comments | « chrome/browser/themes/theme_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_app_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698