chrome/browser/themes/theme_syncable_service.cc - Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_syncable_service.cc

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/browser/themes/theme_syncable_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_syncable_service.cc

diff --git a/chrome/browser/themes/theme_syncable_service.cc b/chrome/browser/themes/theme_syncable_service.cc

index 56fc5ffcc03084dc973a926855b8655c9d18ade8..43e3ff1ebfdbacd8806f693a1480e8d9f076b857 100644

--- a/chrome/browser/themes/theme_syncable_service.cc

+++ b/chrome/browser/themes/theme_syncable_service.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/extensions/extension_system.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/themes/theme_service.h"

+#include "chrome/common/extensions/api/extension_urls/extension_urls_handler.h"

#include "chrome/common/extensions/extension.h"

#include "sync/protocol/sync.pb.h"

#include "sync/protocol/theme_specifics.pb.h"

@@ -268,7 +269,7 @@ void ThemeSyncableService::GetThemeSpecificsFromCurrentTheme(

theme_specifics->set_custom_theme_name(current_theme->name());

theme_specifics->set_custom_theme_id(current_theme->id());

theme_specifics->set_custom_theme_update_url(

- current_theme->update_url().spec());

+ extensions::ExtensionURL::GetUpdateURL(current_theme).spec());

} else {

DCHECK(!current_theme);

theme_specifics->clear_custom_theme_name();

« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/browser/themes/theme_syncable_service_unittest.cc » ('j') | no next file with comments »