Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index 873278153e323e224e1dbb4bcc1a34744ab1ea5c..be3c0a8930dc93b7cb46621091b5d317e07c1fd8 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
#include "chrome/browser/view_type_utils.h"
#include "chrome/common/extensions/api/developer_private.h"
+#include "chrome/common/extensions/api/extension_urls/extension_urls_handler.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
@@ -98,14 +99,16 @@ scoped_ptr<developer::ItemInfo> DeveloperPrivateAPI::CreateItemInfo(
NULL);
info->icon = icon.spec();
- info->homepage_url.reset(new std::string(item.GetHomepageURL().spec()));
- if (!item.options_url().is_empty()) {
- info->options_url.reset(new std::string(item.options_url().spec()));
+ info->homepage_url.reset(new std::string(
+ ExtensionURL::GetHomepageURL(&item).spec()));
+ if (!ExtensionURL::GetOptionsURL(&item).is_empty()) {
+ info->options_url.reset(
+ new std::string(ExtensionURL::GetOptionsURL(&item).spec()));
}
- if (!item.update_url().is_empty()) {
+ if (!ExtensionURL::GetUpdateURL(&item).is_empty()) {
info->update_url.reset(new std::string(
- item.update_url().spec()));
+ ExtensionURL::GetUpdateURL(&item).spec()));
}
if (item.is_app()) {
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/extensions/api/extension_urls/extension_urls_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698