Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1174183004: Templatize functions in htmlediting.cpp (Closed)

Created:
5 years, 6 months ago by yosin_UTC9
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize functions in htmlediting.cpp This patch templatizes functions in "htmlediting.cpp", which are called during constructing |VisblePositon|, for a preparation of making |VisiblePosition| class to work with position in composed tree: - lastEditablePositionBeforePositionInRoot() - nextCandidate() - previousCandidate() - previousVisuallyDistinctCandidate() This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197330

Patch Set 1 #

Patch Set 2 : 2015-06-18T13:23:41 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M Source/core/editing/htmlediting.cpp View 3 chunks +44 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yosin_UTC9
PTAL mac_blink_rel bot failure doesn't relate this patch.
5 years, 6 months ago (2015-06-18 05:26:40 UTC) #2
yosin_UTC9
PTAL
5 years, 6 months ago (2015-06-18 07:29:15 UTC) #4
yosin_UTC9
mac_blink_rel bot failure doesn't relate to this patch.
5 years, 6 months ago (2015-06-18 07:30:36 UTC) #5
tkent
lgtm
5 years, 6 months ago (2015-06-18 07:45:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174183004/20001
5 years, 6 months ago (2015-06-18 07:46:21 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 08:28:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197330

Powered by Google App Engine
This is Rietveld 408576698