Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1174183003: [SP] Enable Slimming Paint by default in Chromium and Blink. (Closed)

Created:
5 years, 6 months ago by wkorman
Modified:
5 years, 6 months ago
Reviewers:
chrishtr, pdr.
CC:
asvitkine+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SP] Enable Slimming Paint by default in Chromium and Blink. Re-do of http://crrev.com/1169193003 Add a --disable-slimming-paint flag and make slimming paint on by default with no flags specified. --enable-slimming-paint takes precedence over --disable-slimming-paint if both are specified. Existence of both flags is required to deal gracefully with Blink-side LayoutTests and a gradual migration. For more, see: https://groups.google.com/a/chromium.org/d/msg/paint-dev/gtRRHn1yotk/f_8iJgHP130J https://groups.google.com/a/chromium.org/d/msg/paint-dev/uVGvSuVilaw/uA3iVa7JpuUJ BUG=497950 TBR=pdr,jam,mpearson,chrishtr,enne Committed: https://crrev.com/260fd855786fb493ad780eb0a5a3681e50d0f941 Cr-Commit-Position: refs/heads/master@{#334686}

Patch Set 1 #

Patch Set 2 : Merge changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
wkorman
5 years, 6 months ago (2015-06-16 18:14:29 UTC) #2
pdr.
TBR'd reviewers: This is the exact same change, but now with many fixes landed that ...
5 years, 6 months ago (2015-06-16 18:17:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174183003/20001
5 years, 6 months ago (2015-06-16 18:25:16 UTC) #5
chrishtr
lgtm
5 years, 6 months ago (2015-06-16 18:29:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 20:46:22 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/260fd855786fb493ad780eb0a5a3681e50d0f941 Cr-Commit-Position: refs/heads/master@{#334686}
5 years, 6 months ago (2015-06-16 20:47:13 UTC) #8
wkorman
5 years, 6 months ago (2015-06-16 20:48:11 UTC) #9
Message was sent while issue was closed.
Sheriff FYI -- I will be OOO ~2pm - 5pm today but on email periodically and
following, please contact pdr@ if I don't respond to any issues.

Powered by Google App Engine
This is Rietveld 408576698