Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1174173013: replace VLOG with DVLOG in content/browser/loader/resource_loader.cc (Closed)

Created:
5 years, 6 months ago by Mostyn Bramley-Moore
Modified:
5 years, 6 months ago
Reviewers:
sque, mmenke
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace VLOG with DVLOG in content/browser/loader/resource_loader.cc VLOG() has a high overhead due to pattern matching. One of the major culprits is in content/browser/loader/resource_loader.cc BUG=489818, 489441 R=sque,mmenke Committed: https://crrev.com/0e79091bb90183eca25e998d2d9e134003313f71 Cr-Commit-Position: refs/heads/master@{#334388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M content/browser/loader/resource_loader.cc View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Mostyn Bramley-Moore
@mmenke: PTAL. Unfortunately I don't have access to go/cwp to see if this still is ...
5 years, 6 months ago (2015-06-15 06:28:45 UTC) #1
mmenke
On 2015/06/15 06:28:45, Mostyn Bramley-Moore wrote: > @mmenke: PTAL. Unfortunately I don't have access to ...
5 years, 6 months ago (2015-06-15 14:57:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174173013/1
5 years, 6 months ago (2015-06-15 14:58:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 16:18:33 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e79091bb90183eca25e998d2d9e134003313f71 Cr-Commit-Position: refs/heads/master@{#334388}
5 years, 6 months ago (2015-06-15 16:19:25 UTC) #6
Simon Que
5 years, 6 months ago (2015-06-15 17:58:10 UTC) #7
Message was sent while issue was closed.
On 2015/06/15 16:19:25, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0e79091bb90183eca25e998d2d9e134003313f71
> Cr-Commit-Position: refs/heads/master@{#334388}

Thanks for making this change, Mostyn.

Changes take several weeks to propagate through the release system. I'll check
it when the time is right, and update the crbug. No need for further action on
your part.

Powered by Google App Engine
This is Rietveld 408576698