runtime/vm/disassembler_ia32.cc - Issue 1174173007: Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 1174173007: Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_ia32.cc

diff --git a/runtime/vm/disassembler_ia32.cc b/runtime/vm/disassembler_ia32.cc

index c3b1d562692b9c7c789d7075189af96a9d2539e6..c63057b80987ea1f5ebf98936fe5d7353b5d0f7c 100644

--- a/runtime/vm/disassembler_ia32.cc

+++ b/runtime/vm/disassembler_ia32.cc

@@ -729,11 +729,6 @@ int X86Decoder::PrintImmediateOp(uint8_t* data, bool size_override) {

default: UNIMPLEMENTED();

}

Print(mnem);

- if (size_override) {

- Print("_w");

- } else if (sign_extension_bit) {

- Print("_b");

- }

Print(" ");

int count = PrintRightOperand(data+1);

Print(",");

« no previous file with comments | « runtime/vm/compiler_test.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »