Issue 1174173002: Remove check before clearing MediaKeys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174173002: Remove check before clearing MediaKeys (Closed)

Created:
4 years, 10 months ago by jrummell

Modified:
4 years, 10 months ago

Reviewers:
ddorwin

CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove check before clearing MediaKeys Remove the check for paused() and let the Chromium side decide what is allowed or not when removing MediaKeys from a MediaPlayer. BUG=none TEST=EME layout tests pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197511

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -12 lines)			Patch
	M	Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp	View		1 chunk	+7 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ddorwin

Description comments: * The first line is a bit confusing. Is there a better way ...

4 years, 10 months ago (2015-06-17 23:23:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174173002/1

4 years, 10 months ago (2015-06-19 23:04:43 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-20 00:25:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197511

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages