create unittest for gm/rebaseline_server/results.py

create unittest for gm/rebaseline_server/results.py

NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=12819

[epoger, 2013-12-20 19:24:38]

Ready for review at patchset 1.

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/tests/i...
File
gm/rebaseline_server/tests/inputs/gm-actuals/Test-Android-GalaxyNexus-SGX540-Arm7-Release/actual-results.json
(right):

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/tests/i...
gm/rebaseline_server/tests/inputs/gm-actuals/Test-Android-GalaxyNexus-SGX540-Arm7-Release/actual-results.json:2:
"actual-results" : {
To create these actual-results.json and expected-results.json files, I copied
them in from production and removed most of the tests (to keep them smaller)

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/tests/o...
File gm/rebaseline_server/tests/outputs/expected/gm.json (right):

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/tests/o...
gm/rebaseline_server/tests/outputs/expected/gm.json:2: "categories": {
I have glanced over this file, but not examined it exhaustively.

It looks reasonable, and it is generated consistently by repeated runs of the
test, so I figure it's right.

[rmistry, 2013-12-23 15:07:54]

LGTM with minor comments

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:13: import argparse
I should start using argparse too, looks like optparse is deprecated in 2.7

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
File gm/rebaseline_server/results_test.py (right):

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:39: GM_DIRECTORY =
os.path.dirname(PARENT_DIRECTORY)
Can instead use results.GM_DIRECTORY ?

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:41: sys.path.append(GM_DIRECTORY)
Is this required? doesnt importing results first add it to the sys.path?

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:94: 
Nit: Add a newline here.

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:102: 
Nit: Add a newline here.

[epoger, 2013-12-23 22:45:43]

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:13: import argparse
On 2013/12/23 15:07:55, rmistry wrote:
> I should start using argparse too, looks like optparse is deprecated in 2.7

Yeah, although the problem is that argparse is not included in the default
Python libraries UNTIL 2.7.  So if you want the code to work in 2.6, argparse is
not an option (unless you install it separately).

I'm not sure what the best thing to do is, given that situation.

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
File gm/rebaseline_server/results_test.py (right):

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:39: GM_DIRECTORY =
os.path.dirname(PARENT_DIRECTORY)
On 2013/12/23 15:07:55, rmistry wrote:
> Can instead use results.GM_DIRECTORY ?

Don't need it at all, thanks to your suggestion below.

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:41: sys.path.append(GM_DIRECTORY)
On 2013/12/23 15:07:55, rmistry wrote:
> Is this required? doesnt importing results first add it to the sys.path?

Good call, I didn't think about that!

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:94: 
On 2013/12/23 15:07:55, rmistry wrote:
> Nit: Add a newline here.

Done.

https://codereview.chromium.org/117413006/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results_test.py:102: 
On 2013/12/23 15:07:55, rmistry wrote:
> Nit: Add a newline here.

Done.

[commit-bot: I haz the power, 2013-12-23 22:46:51]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/117413006/90001

[commit-bot: I haz the power, 2013-12-23 22:47:21]

Change committed as 12819