Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 11741025: Seperate apk_info and jar_info. (Closed)

Created:
7 years, 11 months ago by frankf
Modified:
7 years, 11 months ago
Reviewers:
craigdh, klundberg
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Separate apk_info and jar_info and move to utils dir. This is in preparation for adding uiautomator test runner which runs tests without an apk. BUG=167331 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175082

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Added TOO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -229 lines) Patch
M build/android/adb_install_apk.py View 1 1 chunk +1 line, -1 line 0 comments Download
D build/android/pylib/apk_info.py View 1 chunk +0 lines, -186 lines 0 comments Download
M build/android/pylib/python_test_base.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/run_java_tests.py View 5 chunks +6 lines, -5 lines 0 comments Download
M build/android/pylib/run_python_tests.py View 3 chunks +3 lines, -2 lines 0 comments Download
A build/android/pylib/utils/apk_and_jar_info.py View 1 chunk +22 lines, -0 lines 0 comments Download
A build/android/pylib/utils/apk_info.py View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A + build/android/pylib/utils/jar_info.py View 1 2 5 chunks +7 lines, -30 lines 0 comments Download
M build/android/run_instrumentation_tests.py View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
frankf
7 years, 11 months ago (2013-01-03 23:35:42 UTC) #1
craigdh
lgtm.
7 years, 11 months ago (2013-01-04 01:49:41 UTC) #2
craigdh
https://codereview.chromium.org/11741025/diff/1001/build/android/pylib/utils/apk_info.py File build/android/pylib/utils/apk_info.py (right): https://codereview.chromium.org/11741025/diff/1001/build/android/pylib/utils/apk_info.py#newcode11 build/android/pylib/utils/apk_info.py:11: from pylib import cmd_helper add a TODO to move ...
7 years, 11 months ago (2013-01-04 02:00:32 UTC) #3
frankf
7 years, 11 months ago (2013-01-04 02:11:22 UTC) #4
https://codereview.chromium.org/11741025/diff/1001/build/android/pylib/utils/...
File build/android/pylib/utils/apk_info.py (right):

https://codereview.chromium.org/11741025/diff/1001/build/android/pylib/utils/...
build/android/pylib/utils/apk_info.py:11: from pylib import cmd_helper
Done.
On 2013/01/04 02:00:32, craigdh wrote:
> add a TODO to move cmd_helper to utils/

Powered by Google App Engine
This is Rietveld 408576698