chrome/browser/net/http_server_properties_manager_unittest.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/http_server_properties_manager_unittest.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/variations/variations_service.cc ('K') | « chrome/browser/metrics/variations/variations_service_unittest.cc ('k') | chrome/browser/net/pref_proxy_config_tracker_impl.h » ('j') | chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/http_server_properties_manager_unittest.cc

diff --git a/chrome/browser/net/http_server_properties_manager_unittest.cc b/chrome/browser/net/http_server_properties_manager_unittest.cc

index 6495c23f0707bf2c46bf49f53d667777e388c5fa..a883900d88aee89efe09da9459cc6a4087681556 100644

--- a/chrome/browser/net/http_server_properties_manager_unittest.cc

+++ b/chrome/browser/net/http_server_properties_manager_unittest.cc

@@ -7,6 +7,7 @@

#include "base/basictypes.h"

#include "base/message_loop.h"

#include "base/values.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/common/pref_names.h"

#include "chrome/test/base/testing_pref_service.h"

#include "content/public/test/test_browser_thread.h"

@@ -84,7 +85,8 @@ class HttpServerPropertiesManagerTest : public testing::Test {

}

virtual void SetUp() OVERRIDE {

- pref_service_.RegisterDictionaryPref(prefs::kHttpServerProperties);

+ pref_service_.registry()->RegisterDictionaryPref(

+ prefs::kHttpServerProperties);

http_server_props_manager_.reset(

new StrictMock<TestingHttpServerPropertiesManager>(&pref_service_));

ExpectCacheUpdate();