chrome/browser/metrics/metrics_service.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/external_protocol/external_protocol_handler.cc ('K') | « chrome/browser/metrics/metrics_service.h ('k') | chrome/browser/metrics/variations/variations_service.h » ('j') | chrome/browser/metrics/variations/variations_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index fd5f73f9a13c99413556f83c13938a44d6d60aa5..565f6a3b36846eb7b7e0f4709b96a604e22266df 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -178,6 +178,7 @@

#include "chrome/browser/metrics/tracking_synchronizer.h"

#include "chrome/browser/net/http_pipelining_compatibility_client.h"

#include "chrome/browser/net/network_stats.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/prefs/scoped_user_pref_update.h"

#include "chrome/browser/profiles/profile.h"

@@ -434,7 +435,7 @@ class MetricsMemoryDetails : public MemoryDetails {

};

// static

-void MetricsService::RegisterPrefs(PrefServiceSimple* local_state) {

+void MetricsService::RegisterPrefs(PrefRegistrySimple* local_state) {

DCHECK(IsSingleThreaded());

local_state->RegisterStringPref(prefs::kMetricsClientID, "");

local_state->RegisterIntegerPref(prefs::kMetricsLowEntropySource,