chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/search_engines/keyword_editor_controller.cc ('K') | « chrome/browser/ui/tabs/tab_strip_layout_type_prefs.h ('k') | chrome/browser/ui/webui/flags_ui.h » ('j') | chrome/browser/ui/webui/flags_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc b/chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc

index ef380d560bfcc569ed671a91d3ccace55f5126c9..15c46294763ce9cbcbdfc593040613d1aef80852 100644

--- a/chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc

+++ b/chrome/browser/ui/tabs/tab_strip_layout_type_prefs.cc

@@ -4,17 +4,17 @@

#include "chrome/browser/ui/tabs/tab_strip_layout_type_prefs.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

Mattias Nissler (ping if slow) 2013/01/31 14:50:45 required?

Jói 2013/01/31 16:23:37 Done.

#include "chrome/browser/ui/tabs/tab_strip_layout_type.h"

#include "chrome/common/pref_names.h"

namespace chrome {

-void RegisterTabStripLayoutTypePrefs(PrefServiceSimple* local_state) {

+void RegisterTabStripLayoutTypePrefs(PrefRegistrySimple* registry) {

// This value is device dependant, so it goes in local state.

- local_state->RegisterIntegerPref(

- prefs::kTabStripLayoutType,

- static_cast<int>(TAB_STRIP_LAYOUT_SHRINK));

+ registry->RegisterIntegerPref(prefs::kTabStripLayoutType,

+ static_cast<int>(TAB_STRIP_LAYOUT_SHRINK));

}

} // namespace chrome