chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_view_prefs.cc ('K') | « chrome/browser/ui/cocoa/confirm_quit.h ('k') | chrome/browser/ui/search_engines/keyword_editor_controller.h » ('j') | chrome/browser/ui/search_engines/keyword_editor_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm

diff --git a/chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm b/chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm

index 051a04e59b8503e3289dea701a2d7e7f1a1d4428..1fa6e2c0cb1148f3faf401f77f33d11fa1a26c25 100644

--- a/chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm

+++ b/chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm

@@ -12,6 +12,7 @@

#include "base/metrics/histogram.h"

#include "base/sys_string_conversions.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

Mattias Nissler (ping if slow) 2013/01/31 14:50:45 required?

Jói 2013/01/31 17:29:32 Done.

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -45,8 +46,8 @@ void RecordHistogram(ConfirmQuitMetric sample) {

UMA_HISTOGRAM_ENUMERATION("OSX.ConfirmToQuit", sample, kSampleCount);

}

-void RegisterLocalState(PrefServiceSimple* local_state) {

- local_state->RegisterBooleanPref(prefs::kConfirmToQuitEnabled, false);

+void RegisterLocalState(PrefRegistrySimple* registry) {

+ registry->RegisterBooleanPref(prefs::kConfirmToQuitEnabled, false);

}

} // namespace confirm_quit