chrome/browser/ui/browser_ui_prefs.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_ui_prefs.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_manager/task_manager.cc ('K') | « chrome/browser/ui/browser_ui_prefs.h ('k') | chrome/browser/ui/browser_view_prefs.h » ('j') | chrome/browser/ui/browser_view_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_ui_prefs.cc

diff --git a/chrome/browser/ui/browser_ui_prefs.cc b/chrome/browser/ui/browser_ui_prefs.cc

index 6e945e41e92de550df3e6e23096748517488011b..f51e3e1951e445c8620daa17ab77aa0e7d433662 100644

--- a/chrome/browser/ui/browser_ui_prefs.cc

+++ b/chrome/browser/ui/browser_ui_prefs.cc

@@ -5,16 +5,17 @@

#include "chrome/browser/ui/browser_ui_prefs.h"

#include "chrome/browser/first_run/first_run.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/pref_names.h"

namespace chrome {

-void RegisterBrowserPrefs(PrefServiceSimple* prefs) {

- prefs->RegisterIntegerPref(prefs::kOptionsWindowLastTabIndex, 0);

- prefs->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true);

- prefs->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption,

+void RegisterBrowserPrefs(PrefRegistrySimple* registry) {

+ registry->RegisterIntegerPref(prefs::kOptionsWindowLastTabIndex, 0);

+ registry->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true);

+ registry->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption,

first_run::FIRST_RUN_BUBBLE_DONT_SHOW);

}