chrome/browser/signin/signin_manager_factory.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_manager_factory.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/pref_service_builder.h ('K') | « chrome/browser/signin/signin_manager_factory.h ('k') | chrome/browser/signin/signin_manager_unittest.cc » ('j') | chrome/browser/task_manager/task_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_manager_factory.cc

diff --git a/chrome/browser/signin/signin_manager_factory.cc b/chrome/browser/signin/signin_manager_factory.cc

index c09f4dedc72a734afc03c1fe297f65d982e63c03..4df64017470f969f0013b4d35669e3681470be38 100644

--- a/chrome/browser/signin/signin_manager_factory.cc

+++ b/chrome/browser/signin/signin_manager_factory.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/signin/signin_manager_factory.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

Mattias Nissler (ping if slow) 2013/01/31 14:50:45 needed?

Jói 2013/01/31 16:23:37 Done.

#include "chrome/browser/profiles/profile_dependency_manager.h"

#include "chrome/browser/signin/signin_manager.h"

@@ -54,8 +55,8 @@ void SigninManagerFactory::RegisterUserPrefs(PrefServiceSyncable* user_prefs) {

}

// static

-void SigninManagerFactory::RegisterPrefs(PrefServiceSimple* local_state) {

- local_state->RegisterStringPref(prefs::kGoogleServicesUsernamePattern, "");

+void SigninManagerFactory::RegisterPrefs(PrefRegistrySimple* registry) {

+ registry->RegisterStringPref(prefs::kGoogleServicesUsernamePattern, "");

}

ProfileKeyedService* SigninManagerFactory::BuildServiceInstanceFor(