chrome/browser/metrics/variations/variations_service.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix double registration in Chrome Frame test. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/variations/variations_service.h ('k') | chrome/browser/metrics/variations/variations_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/variations_service.cc

diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc

index 82b751050c7f361dc0c06ddddebff08bb3699da9..3f0adbec543948c735326eda3065ee39ed931f8d 100644

--- a/chrome/browser/metrics/variations/variations_service.cc

+++ b/chrome/browser/metrics/variations/variations_service.cc

@@ -15,6 +15,7 @@

#include "base/version.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/metrics/proto/trials_seed.pb.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/metrics/variations/variations_util.h"

@@ -198,10 +199,10 @@ void VariationsService::SetCreateTrialsFromSeedCalledForTesting(bool called) {

}

// static

-void VariationsService::RegisterPrefs(PrefServiceSimple* prefs) {

- prefs->RegisterStringPref(prefs::kVariationsSeed, std::string());

- prefs->RegisterInt64Pref(prefs::kVariationsSeedDate,

- base::Time().ToInternalValue());

+void VariationsService::RegisterPrefs(PrefRegistrySimple* registry) {

+ registry->RegisterStringPref(prefs::kVariationsSeed, std::string());

+ registry->RegisterInt64Pref(prefs::kVariationsSeedDate,

+ base::Time().ToInternalValue());

}

// static