Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: chrome/browser/metrics/metrics_service.h

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file defines a service that collects information about the user 5 // This file defines a service that collects information about the user
6 // experience in order to help improve future versions of the app. 6 // experience in order to help improve future versions of the app.
7 7
8 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_ 8 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
9 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_ 9 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
10 10
(...skipping 14 matching lines...) Expand all
25 #include "content/public/browser/notification_observer.h" 25 #include "content/public/browser/notification_observer.h"
26 #include "content/public/browser/notification_registrar.h" 26 #include "content/public/browser/notification_registrar.h"
27 #include "net/url_request/url_fetcher_delegate.h" 27 #include "net/url_request/url_fetcher_delegate.h"
28 28
29 #if defined(OS_CHROMEOS) 29 #if defined(OS_CHROMEOS)
30 #include "chrome/browser/chromeos/external_metrics.h" 30 #include "chrome/browser/chromeos/external_metrics.h"
31 #endif 31 #endif
32 32
33 class MetricsReportingScheduler; 33 class MetricsReportingScheduler;
34 class PrefService; 34 class PrefService;
35 class PrefServiceSimple; 35 class PrefRegistrySimple;
36 class Profile; 36 class Profile;
37 class TemplateURLService; 37 class TemplateURLService;
38 38
39 namespace base { 39 namespace base {
40 class DictionaryValue; 40 class DictionaryValue;
41 class MessageLoopProxy; 41 class MessageLoopProxy;
42 } 42 }
43 43
44 namespace content { 44 namespace content {
45 class RenderProcessHost; 45 class RenderProcessHost;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 // to be started. 115 // to be started.
116 scoped_ptr<const base::FieldTrial::EntropyProvider> CreateEntropyProvider( 116 scoped_ptr<const base::FieldTrial::EntropyProvider> CreateEntropyProvider(
117 bool reporting_will_be_enabled); 117 bool reporting_will_be_enabled);
118 118
119 // Force the client ID to be generated. This is useful in case it's needed 119 // Force the client ID to be generated. This is useful in case it's needed
120 // before recording. 120 // before recording.
121 void ForceClientIdCreation(); 121 void ForceClientIdCreation();
122 122
123 // At startup, prefs needs to be called with a list of all the pref names and 123 // At startup, prefs needs to be called with a list of all the pref names and
124 // types we'll be using. 124 // types we'll be using.
125 static void RegisterPrefs(PrefServiceSimple* local_state); 125 static void RegisterPrefs(PrefRegistrySimple* local_state);
126 126
127 // Set up notifications which indicate that a user is performing work. This is 127 // Set up notifications which indicate that a user is performing work. This is
128 // useful to allow some features to sleep, until the machine becomes active, 128 // useful to allow some features to sleep, until the machine becomes active,
129 // such as precluding UMA uploads unless there was recent activity. 129 // such as precluding UMA uploads unless there was recent activity.
130 static void SetUpNotifications(content::NotificationRegistrar* registrar, 130 static void SetUpNotifications(content::NotificationRegistrar* registrar,
131 content::NotificationObserver* observer); 131 content::NotificationObserver* observer);
132 132
133 // Implementation of content::NotificationObserver 133 // Implementation of content::NotificationObserver
134 virtual void Observe(int type, 134 virtual void Observe(int type,
135 const content::NotificationSource& source, 135 const content::NotificationSource& source,
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 friend class extensions::ExtensionDownloader; 516 friend class extensions::ExtensionDownloader;
517 friend class extensions::ManifestFetchData; 517 friend class extensions::ManifestFetchData;
518 518
519 // Returns true if prefs::kMetricsReportingEnabled is set. 519 // Returns true if prefs::kMetricsReportingEnabled is set.
520 static bool IsMetricsReportingEnabled(); 520 static bool IsMetricsReportingEnabled();
521 521
522 DISALLOW_IMPLICIT_CONSTRUCTORS(MetricsServiceHelper); 522 DISALLOW_IMPLICIT_CONSTRUCTORS(MetricsServiceHelper);
523 }; 523 };
524 524
525 #endif // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_ 525 #endif // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698