Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: chrome/browser/external_protocol/external_protocol_handler.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/external_protocol/external_protocol_handler.h" 5 #include "chrome/browser/external_protocol/external_protocol_handler.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/message_loop.h" 11 #include "base/message_loop.h"
12 #include "base/string_util.h" 12 #include "base/string_util.h"
13 #include "base/threading/thread.h" 13 #include "base/threading/thread.h"
14 #include "build/build_config.h" 14 #include "build/build_config.h"
15 #include "chrome/browser/browser_process.h" 15 #include "chrome/browser/browser_process.h"
16 #include "chrome/browser/platform_util.h" 16 #include "chrome/browser/platform_util.h"
17 #include "chrome/browser/prefs/pref_registry_simple.h"
18 #include "chrome/browser/prefs/pref_registry_simple.h"
Mattias Nissler (ping if slow) 2013/01/31 13:06:25 once is enough :)
Jói 2013/01/31 13:43:42 Done.
17 #include "chrome/browser/prefs/pref_service.h" 19 #include "chrome/browser/prefs/pref_service.h"
18 #include "chrome/browser/prefs/scoped_user_pref_update.h" 20 #include "chrome/browser/prefs/scoped_user_pref_update.h"
19 #include "chrome/common/pref_names.h" 21 #include "chrome/common/pref_names.h"
20 #include "content/public/browser/browser_thread.h" 22 #include "content/public/browser/browser_thread.h"
21 #include "googleurl/src/gurl.h" 23 #include "googleurl/src/gurl.h"
22 #include "net/base/escape.h" 24 #include "net/base/escape.h"
23 25
24 using content::BrowserThread; 26 using content::BrowserThread;
25 27
26 // Whether we accept requests for launching external protocols. This is set to 28 // Whether we accept requests for launching external protocols. This is set to
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 // Otherwise put this work on the file thread. On Windows ShellExecute may 291 // Otherwise put this work on the file thread. On Windows ShellExecute may
290 // block for a significant amount of time, and it shouldn't hurt on Linux. 292 // block for a significant amount of time, and it shouldn't hurt on Linux.
291 BrowserThread::PostTask( 293 BrowserThread::PostTask(
292 BrowserThread::FILE, 294 BrowserThread::FILE,
293 FROM_HERE, 295 FROM_HERE,
294 base::Bind(&platform_util::OpenExternal, url)); 296 base::Bind(&platform_util::OpenExternal, url));
295 #endif 297 #endif
296 } 298 }
297 299
298 // static 300 // static
299 void ExternalProtocolHandler::RegisterPrefs(PrefServiceSimple* prefs) { 301 void ExternalProtocolHandler::RegisterPrefs(PrefRegistrySimple* prefs) {
300 prefs->RegisterDictionaryPref(prefs::kExcludedSchemes); 302 prefs->RegisterDictionaryPref(prefs::kExcludedSchemes);
301 } 303 }
302 304
303 // static 305 // static
304 void ExternalProtocolHandler::PermitLaunchUrl() { 306 void ExternalProtocolHandler::PermitLaunchUrl() {
305 DCHECK_EQ(MessageLoop::TYPE_UI, MessageLoop::current()->type()); 307 DCHECK_EQ(MessageLoop::TYPE_UI, MessageLoop::current()->type());
306 g_accept_requests = true; 308 g_accept_requests = true;
307 } 309 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698