Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/browser/upgrade_detector.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/upgrade_detector.h" 5 #include "chrome/browser/upgrade_detector.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/browser/lifetime/application_lifetime.h"
10 #include "chrome/browser/prefs/pref_registry_simple.h"
9 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
Mattias Nissler (ping if slow) 2013/01/31 14:50:45 required?
Jói 2013/01/31 16:23:37 Done.
10 #include "chrome/browser/lifetime/application_lifetime.h"
11 #include "chrome/browser/ui/browser_otr_state.h" 12 #include "chrome/browser/ui/browser_otr_state.h"
12 #include "chrome/common/chrome_notification_types.h" 13 #include "chrome/common/chrome_notification_types.h"
13 #include "chrome/common/chrome_switches.h" 14 #include "chrome/common/chrome_switches.h"
14 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
15 #include "content/public/browser/notification_service.h" 16 #include "content/public/browser/notification_service.h"
16 #include "grit/theme_resources.h" 17 #include "grit/theme_resources.h"
17 18
18 // How long to wait between checks for whether the user has been idle. 19 // How long to wait between checks for whether the user has been idle.
19 static const int kIdleRepeatingTimerWait = 10; // Minutes (seconds if testing). 20 static const int kIdleRepeatingTimerWait = 10; // Minutes (seconds if testing).
20 21
21 // How much idle time (since last input even was detected) must have passed 22 // How much idle time (since last input even was detected) must have passed
22 // until we notify that a critical update has occurred. 23 // until we notify that a critical update has occurred.
23 static const int kIdleAmount = 2; // Hours (or seconds, if testing). 24 static const int kIdleAmount = 2; // Hours (or seconds, if testing).
24 25
25 bool UseTestingIntervals() { 26 bool UseTestingIntervals() {
26 // If a command line parameter specifying how long the upgrade check should 27 // If a command line parameter specifying how long the upgrade check should
27 // be, we assume it is for testing and switch to using seconds instead of 28 // be, we assume it is for testing and switch to using seconds instead of
28 // hours. 29 // hours.
29 const CommandLine& cmd_line = *CommandLine::ForCurrentProcess(); 30 const CommandLine& cmd_line = *CommandLine::ForCurrentProcess();
30 return !cmd_line.GetSwitchValueASCII( 31 return !cmd_line.GetSwitchValueASCII(
31 switches::kCheckForUpdateIntervalSec).empty(); 32 switches::kCheckForUpdateIntervalSec).empty();
32 } 33 }
33 34
34 // static 35 // static
35 void UpgradeDetector::RegisterPrefs(PrefServiceSimple* prefs) { 36 void UpgradeDetector::RegisterPrefs(PrefRegistrySimple* registry) {
36 prefs->RegisterBooleanPref(prefs::kRestartLastSessionOnShutdown, false); 37 registry->RegisterBooleanPref(prefs::kRestartLastSessionOnShutdown, false);
37 prefs->RegisterBooleanPref(prefs::kWasRestarted, false); 38 registry->RegisterBooleanPref(prefs::kWasRestarted, false);
38 } 39 }
39 40
40 int UpgradeDetector::GetIconResourceID(UpgradeNotificationIconType type) { 41 int UpgradeDetector::GetIconResourceID(UpgradeNotificationIconType type) {
41 bool badge = type == UPGRADE_ICON_TYPE_BADGE; 42 bool badge = type == UPGRADE_ICON_TYPE_BADGE;
42 switch (upgrade_notification_stage_) { 43 switch (upgrade_notification_stage_) {
43 case UPGRADE_ANNOYANCE_CRITICAL: 44 case UPGRADE_ANNOYANCE_CRITICAL:
44 // The critical annoyance state, somewhat ironically, re-purposes the 45 // The critical annoyance state, somewhat ironically, re-purposes the
45 // icon for the second highest severity state, since that state has the 46 // icon for the second highest severity state, since that state has the
46 // icon most closely resembling the one requested of this feature and the 47 // icon most closely resembling the one requested of this feature and the
47 // critical annoyance is never part of the sliding scale of severity 48 // critical annoyance is never part of the sliding scale of severity
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 break; 126 break;
126 case IDLE_STATE_ACTIVE: 127 case IDLE_STATE_ACTIVE:
127 case IDLE_STATE_UNKNOWN: 128 case IDLE_STATE_UNKNOWN:
128 break; 129 break;
129 default: 130 default:
130 NOTREACHED(); // Need to add any new value above (either providing 131 NOTREACHED(); // Need to add any new value above (either providing
131 // automatic restart or show notification to user). 132 // automatic restart or show notification to user).
132 break; 133 break;
133 } 134 }
134 } 135 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698