Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: chrome/browser/prefs/pref_service_builder.h

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_ 5 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_
6 #define CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_ 6 #define CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h"
Mattias Nissler (ping if slow) 2013/01/31 14:50:45 not needed I guess?
Jói 2013/01/31 16:23:37 Done.
11 #include "base/prefs/persistent_pref_store.h" 12 #include "base/prefs/persistent_pref_store.h"
12 #include "base/prefs/pref_store.h" 13 #include "base/prefs/pref_store.h"
14 #include "chrome/browser/prefs/pref_registry.h"
13 15
14 class FilePath; 16 class FilePath;
15 class PrefServiceSimple; 17 class PrefService;
16 18
17 namespace base { 19 namespace base {
18 class SequencedTaskRunner; 20 class SequencedTaskRunner;
19 } 21 }
20 22
21 // A class that allows convenient building of PrefService. 23 // A class that allows convenient building of PrefService.
22 class PrefServiceBuilder { 24 class PrefServiceBuilder {
23 public: 25 public:
24 PrefServiceBuilder(); 26 PrefServiceBuilder();
25 virtual ~PrefServiceBuilder(); 27 virtual ~PrefServiceBuilder();
(...skipping 12 matching lines...) Expand all
38 const base::Callback<void(PersistentPrefStore::PrefReadError)>& 40 const base::Callback<void(PersistentPrefStore::PrefReadError)>&
39 read_error_callback); 41 read_error_callback);
40 42
41 // Specifies to use an actual file-backed user pref store. 43 // Specifies to use an actual file-backed user pref store.
42 PrefServiceBuilder& WithUserFilePrefs( 44 PrefServiceBuilder& WithUserFilePrefs(
43 const FilePath& prefs_file, 45 const FilePath& prefs_file,
44 base::SequencedTaskRunner* task_runner); 46 base::SequencedTaskRunner* task_runner);
45 47
46 PrefServiceBuilder& WithAsync(bool async); 48 PrefServiceBuilder& WithAsync(bool async);
47 49
48 // Creates a PrefServiceSimple object initialized with the 50 // Creates a PrefService object initialized with the parameters from
49 // parameters from this builder. 51 // this builder.
50 virtual PrefServiceSimple* CreateSimple(); 52 virtual PrefService* Create(PrefRegistry* registry);
51 53
52 protected: 54 protected:
53 virtual void ResetDefaultState(); 55 virtual void ResetDefaultState();
54 56
55 scoped_refptr<PrefStore> managed_prefs_; 57 scoped_refptr<PrefStore> managed_prefs_;
56 scoped_refptr<PrefStore> extension_prefs_; 58 scoped_refptr<PrefStore> extension_prefs_;
57 scoped_refptr<PrefStore> command_line_prefs_; 59 scoped_refptr<PrefStore> command_line_prefs_;
58 scoped_refptr<PersistentPrefStore> user_prefs_; 60 scoped_refptr<PersistentPrefStore> user_prefs_;
59 scoped_refptr<PrefStore> recommended_prefs_; 61 scoped_refptr<PrefStore> recommended_prefs_;
60 62
61 base::Callback<void(PersistentPrefStore::PrefReadError)> read_error_callback_; 63 base::Callback<void(PersistentPrefStore::PrefReadError)> read_error_callback_;
62 64
63 // Defaults to false. 65 // Defaults to false.
64 bool async_; 66 bool async_;
65 67
66 private: 68 private:
67 DISALLOW_COPY_AND_ASSIGN(PrefServiceBuilder); 69 DISALLOW_COPY_AND_ASSIGN(PrefServiceBuilder);
68 }; 70 };
69 71
70 #endif // CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_ 72 #endif // CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698