Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

chrome/browser/prefs/pref_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This provides a way to access the application's current preferences.
 
 // Chromium settings and storage represent user-selected preferences and
 // information and MUST not be extracted, overwritten or modified except
 // through Chromium defined APIs.
 
 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_H_
 #define CHROME_BROWSER_PREFS_PREF_SERVICE_H_
 
 #include <set>
 #include <string>
 
 #include "base/callback.h"
+#include "base/hash_tables.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/hash_tables.h"
 #include "base/observer_list.h"
 #include "base/prefs/persistent_pref_store.h"
 #include "base/prefs/public/pref_service_base.h"
 #include "base/threading/non_thread_safe.h"
 
 class DefaultPrefStore;
 class PrefNotifier;
 class PrefNotifierImpl;
 class PrefObserver;
+class PrefRegistry;
 class PrefStore;
 class PrefValueStore;
 
 namespace subtle {
 class ScopedUserPrefUpdateBase;
 };
 
 // Base class for PrefServices. You can use the base class to read and
 // interact with preferences, but not to register new preferences; for
-// that see subclasses like PrefServiceSimple.
+// that see e.g. PrefRegistrySimple.
 class PrefService : public PrefServiceBase, public base::NonThreadSafe {
  public:
   enum PrefInitializationStatus {
     INITIALIZATION_STATUS_WAITING,
     INITIALIZATION_STATUS_SUCCESS,
     INITIALIZATION_STATUS_CREATED_NEW_PROFILE,
     INITIALIZATION_STATUS_ERROR
   };
 
   // A helper class to store all the information associated with a preference.
@@ skipping 37 matching lines @@
     // Reference to the PrefService in which this pref was created.
     const PrefService* pref_service_;
   };
 
   // You may wish to use PrefServiceBuilder or one of its subclasses
   // for simplified construction.
   PrefService(
       PrefNotifierImpl* pref_notifier,
       PrefValueStore* pref_value_store,
       PersistentPrefStore* user_prefs,
-      DefaultPrefStore* default_store,
+      scoped_ptr<PrefRegistry> pref_registry,
       base::Callback<void(PersistentPrefStore::PrefReadError)>
           read_error_callback,
       bool async);
   virtual ~PrefService();
 
   // Reloads the data from file. This should only be called when the importer
   // is running during first run, and the main process may not change pref
   // values while the importer process is running. Returns true on success.
   bool ReloadPersistentPrefs();
 
   // Lands pending writes to disk. This should only be used if we need to save
   // immediately (basically, during shutdown).
   void CommitPendingWrite();
 
   // PrefServiceBase implementation.
   virtual bool IsManagedPreference(const char* pref_name) const OVERRIDE;
   virtual bool IsUserModifiablePreference(const char* pref_name) const OVERRIDE;
-  virtual void UnregisterPreference(const char* path) OVERRIDE;
   virtual const PrefService::Preference* FindPreference(
       const char* path) const OVERRIDE;
   virtual bool GetBoolean(const char* path) const OVERRIDE;
   virtual int GetInteger(const char* path) const OVERRIDE;
   virtual double GetDouble(const char* path) const OVERRIDE;
   virtual std::string GetString(const char* path) const OVERRIDE;
   virtual FilePath GetFilePath(const char* path) const OVERRIDE;
   virtual const base::DictionaryValue* GetDictionary(
       const char* path) const OVERRIDE;
   virtual const base::ListValue* GetList(const char* path) const OVERRIDE;
@@ skipping 33 matching lines @@
 
   // Tell our PrefValueStore to update itself to |command_line_store|.
   // Takes ownership of the store.
   virtual void UpdateCommandLinePrefStore(PrefStore* command_line_store);
 
   // We run the callback once, when initialization completes. The bool
   // parameter will be set to true for successful initialization,
   // false for unsuccessful.
   void AddPrefInitObserver(base::Callback<void(bool)> callback);
 
+  // Returns the PrefRegistry object for this service. You should not
+  // use this; the intent is for no registrations to take place after
+  // PrefService has been constructed.
+  PrefRegistry* DeprecatedGetPrefRegistry() const;

[Mattias Nissler (ping if slow), 2013/01/25 14:57:11]

Does this have to be const? The caller can change state by manipulating
PrefRegistry, so the const is inaccurate.

[Jói, 2013/01/29 16:10:02]

Done.

+
  protected:
+  friend class PrefRegistry;
+
+  // Registers the preferences from the PrefRegistry instance passed
+  // to us at construction time.
+  void RegisterInitialPreferences();
+
   // Registers a new preference at |path|. The |default_value| must not be
   // NULL as it determines the preference value's type.
   // RegisterPreference must not be called twice for the same path.
-  // This method takes ownership of |default_value|.
-  void RegisterPreference(const char* path, base::Value* default_value);
+  //
+  // If |in_default_store| is true, the preference must already
+  // exist in default_store_. If not, it is added to default_store_.
+  void RegisterPreference(const char* path,
+                          base::Value* default_value,
+                          bool in_default_store);
+
+  void UnregisterPreference(const char* path);
+
+  // Subclasses should override this to return false if they do not
+  // wish to allow PrefRegistrySimple to be used to register
+  // preferences on this object, e.g. if they wish to ensure more
+  // parameters are given for each registration than
+  // PrefRegistrySimple takes.
+  virtual bool AllowPrefRegistrarSimple() const;

[Mattias Nissler (ping if slow), 2013/01/25 14:57:11]

Why would we need that? Subclasses that need more should take a pointer of the
appropriate type in their ctor.

[Jói, 2013/01/29 16:10:02]

Gone.

 
   // The PrefNotifier handles registering and notifying preference observers.
   // It is created and owned by this PrefService. Subclasses may access it for
   // unit testing.
   scoped_ptr<PrefNotifierImpl> pref_notifier_;
 
   // The PrefValueStore provides prioritized preference values. It is owned by
   // this PrefService. Subclasses may access it for unit testing.
   scoped_ptr<PrefValueStore> pref_value_store_;
 
   // Pref Stores and profile that we passed to the PrefValueStore.
   scoped_refptr<PersistentPrefStore> user_pref_store_;
   scoped_refptr<DefaultPrefStore> default_store_;
 
   // Callback to call when a read error occurs.
   base::Callback<void(PersistentPrefStore::PrefReadError)> read_error_callback_;
 
  private:
   // Hash map expected to be fastest here since it minimises expensive
   // string comparisons. Order is unimportant, and deletions are rare.
   // Confirmed on Android where this speeded Chrome startup by roughly 50ms
   // vs. std::map, and by roughly 180ms vs. std::set of Preference pointers.
   typedef base::hash_map<std::string, Preference> PreferenceMap;
 
-  // Give access to Initialize().
-  friend class PrefServiceBuilder;
-
   // Give access to ReportUserPrefChanged() and GetMutableUserPref().
   friend class subtle::ScopedUserPrefUpdateBase;
 
   // PrefServiceBase implementation (protected in base, private here).
   virtual void AddPrefObserver(const char* path,
                                PrefObserver* obs) OVERRIDE;
   virtual void RemovePrefObserver(const char* path,
                                   PrefObserver* obs) OVERRIDE;
 
   // Sends notification of a changed preference. This needs to be called by
@@ skipping 23 matching lines @@
   // not need to find or create a Preference object to get the
   // value (GetValue() calls back though the preference service to
   // actually get the value.).
   const base::Value* GetPreferenceValue(const std::string& path) const;
 
   // Local cache of registered Preference objects. The default_store_
   // is authoritative with respect to what the types and default values
   // of registered preferences are.
   mutable PreferenceMap prefs_map_;
 
+  scoped_ptr<PrefRegistry> pref_registry_;
+
   DISALLOW_COPY_AND_ASSIGN(PrefService);
 };
 
 // TODO(joi): Remove these forwards. They were placed here temporarily
 // to limit the size of the initial change that split
 // PrefServiceSimple and PrefServiceSyncable out of PrefService.
-#include "chrome/browser/prefs/pref_service_simple.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 
 #endif  // CHROME_BROWSER_PREFS_PREF_SERVICE_H_