net/http/http_response_info.h - Issue 1174073003: Add served cert chain to SSLInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_info.h

Issue 1174073003: Add served cert chain to SSLInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update HttpResponseInfo::ssl_info comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_info.h

diff --git a/net/http/http_response_info.h b/net/http/http_response_info.h

index e6d5ba1e22f29c6eb4f633afb90a3b2cee5a3d7e..1ce64f82698bb0b43703916b47011a5f7b0f1022 100644

--- a/net/http/http_response_info.h

+++ b/net/http/http_response_info.h

@@ -139,7 +139,9 @@ class NET_EXPORT HttpResponseInfo {

// challenge, client certificate request is not part of an HTTP response.

scoped_refptr<SSLCertRequestInfo> cert_request_info;

- // The SSL connection info (if HTTPS).

+ // The SSL connection info (if HTTPS). Note that when a response is

+ // served from cache, not every field is present. See

+ // HttpResponseInfo::InitFromPickle().

SSLInfo ssl_info;

// The parsed response headers and status line.

« no previous file with comments | « no previous file | net/socket/socket_test_util.h » ('j') | net/socket/ssl_client_socket_unittest.cc » ('J')