Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: mojo/common/handle_watcher.cc

Issue 1174063002: Remove use of MessageLoopProxy (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/content_handler_factory.cc ('k') | mojo/edk/embedder/embedder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/handle_watcher.cc
diff --git a/mojo/common/handle_watcher.cc b/mojo/common/handle_watcher.cc
index 05f82b13ee589324f62d2d8b152fda3d86bb48c6..c7fa81fd8a10a3550b2f4ed9c40cbb12ea09c6ea 100644
--- a/mojo/common/handle_watcher.cc
+++ b/mojo/common/handle_watcher.cc
@@ -14,9 +14,9 @@
#include "base/memory/singleton.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
-#include "base/message_loop/message_loop_proxy.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
+#include "base/thread_task_runner_handle.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "base/time/time.h"
@@ -43,14 +43,14 @@ struct WatchData {
WatchData()
: id(0),
handle_signals(MOJO_HANDLE_SIGNAL_NONE),
- message_loop(NULL) {}
+ task_runner(NULL) {}
WatcherID id;
Handle handle;
MojoHandleSignals handle_signals;
base::TimeTicks deadline;
base::Callback<void(MojoResult)> callback;
- scoped_refptr<base::MessageLoopProxy> message_loop;
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner;
};
// WatcherBackend --------------------------------------------------------------
@@ -123,7 +123,7 @@ void WatcherBackend::RemoveAndNotify(const Handle& handle,
const WatchData data(handle_to_data_[handle]);
handle_to_data_.erase(handle);
MessagePumpMojo::current()->RemoveHandler(handle);
- data.message_loop->PostTask(FROM_HERE, base::Bind(data.callback, result));
+ data.task_runner->PostTask(FROM_HERE, base::Bind(data.callback, result));
}
bool WatcherBackend::GetMojoHandleByWatcherID(WatcherID watcher_id,
@@ -237,9 +237,7 @@ WatcherID WatcherThreadManager::StartWatching(
request_data.start_data.callback = callback;
request_data.start_data.handle_signals = handle_signals;
request_data.start_data.deadline = deadline;
- request_data.start_data.message_loop = base::MessageLoopProxy::current();
- DCHECK_NE(static_cast<base::MessageLoopProxy*>(NULL),
- request_data.start_data.message_loop.get());
+ request_data.start_data.task_runner = base::ThreadTaskRunnerHandle::Get();
AddRequest(request_data);
return request_data.start_data.id;
}
@@ -279,7 +277,7 @@ void WatcherThreadManager::AddRequest(const RequestData& data) {
return;
}
// We own |thread_|, so it's safe to use Unretained() here.
- thread_.message_loop()->PostTask(
+ thread_.task_runner()->PostTask(
FROM_HERE,
base::Bind(&WatcherThreadManager::ProcessRequestsOnBackendThread,
base::Unretained(this)));
« no previous file with comments | « mojo/application/content_handler_factory.cc ('k') | mojo/edk/embedder/embedder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698