Issue 1174063002: Remove use of MessageLoopProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174063002: Remove use of MessageLoopProxy (Closed)

Created:
5 years, 6 months ago by Sami

Modified:
5 years, 6 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove use of MessageLoopProxy Remove the usage of base::MessageLoopProxy since it has been deprecated. BUG=465354 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b454cd3c3690a572c775aff6312a7359d410d46d

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -23 lines)			Patch
M	mojo/application/content_handler_factory.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	mojo/common/handle_watcher.cc	View	5 chunks	+6 lines, -8 lines	0 comments	Download
M	mojo/edk/embedder/embedder.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/edk/system/channel_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/edk/system/channel_manager_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	shell/child_main.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	shell/in_process_native_runner.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	shell/task_runners.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/document_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

Thanks, LGTM. (If it doesn't let you commit this, I can land it for you.)

5 years, 6 months ago (2015-06-10 17:13:59 UTC) #3

Sami

Thanks, looks like it's not letting me land this: $ git cl land ... Permission ...

5 years, 6 months ago (2015-06-10 17:19:44 UTC) #4

viettrungluu

5 years, 6 months ago (2015-06-10 17:24:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b454cd3c3690a572c775aff6312a7359d410d46d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages