Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(119)

Issue 1174053003: Revert of Remove some duplicated code when accounting for floats at line-end (Closed)

Created:
4 years, 10 months ago by rhogan
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove some duplicated code when accounting for floats at line-end (patchset #1 id:1 of https://codereview.chromium.org/1152953002/) Reason for revert: Together with https://codereview.chromium.org/1132103007 caused issues with layout identified in crbug.com/498664. Reverting both patches. Original issue's description: > Remove some duplicated code when accounting for floats at line-end > > This results in less code, but not that much less. The real win is in moving the > quite cumbersome logic to a place where it's not obscuring the purpose of the > functions it lives in. > > BUG=487775 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196012 TBR=leviw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -36 lines) Patch
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +42 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rhogan
Created Revert of Remove some duplicated code when accounting for floats at line-end
4 years, 10 months ago (2015-06-10 18:25:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174053003/1
4 years, 10 months ago (2015-06-10 18:25:43 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 18:26:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196888

Powered by Google App Engine
This is Rietveld 408576698