Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: sky/sdk/lib/framework/components2/button_base.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/components2/button_base.dart
diff --git a/sky/sdk/lib/framework/components2/button_base.dart b/sky/sdk/lib/framework/components2/button_base.dart
index 8e507f5adc82b03f829cb818abe6d4cedaf83ec1..1c97e57d97ebf143a9ed57f2504cca685829d4f6 100644
--- a/sky/sdk/lib/framework/components2/button_base.dart
+++ b/sky/sdk/lib/framework/components2/button_base.dart
@@ -6,21 +6,15 @@ import '../fn2.dart';
abstract class ButtonBase extends Component {
- ButtonBase({ Object key }) : super(key: key);
+ ButtonBase({ Object key, this.highlight }) : super(key: key);
- UINode buildContent();
+ bool highlight = false;
- UINode build() {
- return new EventListenerNode(
- buildContent(),
- onPointerDown: _handlePointerDown,
- onPointerUp: _handlePointerUp,
- onPointerCancel: _handlePointerCancel
- );
+ void syncFields(ButtonBase source) {
+ highlight = source.highlight;
+ super.syncFields(source);
}
- bool highlight = false;
-
void _handlePointerDown(_) {
setState(() {
highlight = true;
@@ -36,4 +30,16 @@ abstract class ButtonBase extends Component {
highlight = false;
});
}
+
+ UINode build() {
+ return new EventListenerNode(
+ buildContent(),
+ onPointerDown: _handlePointerDown,
+ onPointerUp: _handlePointerUp,
+ onPointerCancel: _handlePointerCancel
+ );
+ }
+
+ UINode buildContent();
+
}

Powered by Google App Engine
This is Rietveld 408576698