sky/examples/stocks2/lib/stock_row.dart - Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/stocks2/lib/stock_row.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/examples/stocks2/lib/stock_menu.dart ('k') | sky/sdk/lib/framework/components2/button.dart » ('j') | sky/sdk/lib/framework/components2/fixed_height_scrollable.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/examples/stocks2/lib/stock_row.dart

diff --git a/sky/examples/stocks2/lib/stock_row.dart b/sky/examples/stocks2/lib/stock_row.dart

index 4aea39c11b7b0789ef0c432cb87b3b2f58293dc9..f71b4555abe931d70e1bec2e0c20e327114fc5ba 100644

--- a/sky/examples/stocks2/lib/stock_row.dart

+++ b/sky/examples/stocks2/lib/stock_row.dart

@@ -12,14 +12,18 @@ import 'stock_arrow.dart';

import 'stock_data.dart';

class StockRow extends Component {

- static const double kHeight = 70.0;

+ StockRow({ this.stock }) : super(key: stock.symbol);

Stock stock;

- StockRow({ Stock stock }) : super(key: stock.symbol) {

- this.stock = stock;

+ void syncFields(StockRow source) {

+ stock = source.stock;

+ super.syncFields(source);

}

+ static const double kHeight = 70.0;

UINode build() {

String lastSale = "\$${stock.lastSale.toStringAsFixed(2)}";