Issue 11740035: Don't access owner() in the constructor; eventually doing this won't work, because InfoBarDelegates…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11740035: Don't access owner() in the constructor; eventually doing this won't work, because InfoBarDelegates… (Closed)

Created:
7 years, 11 months ago by Peter Kasting

Modified:
7 years, 11 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Don't access owner() in the constructor; eventually doing this won't work, because InfoBarDelegates won't be owned at creation. (It's fine right now, but this is more efficient anyway, since the caller already has a Browser*.) BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175242

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/ui/startup/session_crashed_prompt.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages