Issue 11740034: Rename AppNotifyChannelUIImpl::InfoBar to AppNotifyChannelUIInfoBarDelegate for consistency with ot…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11740034: Rename AppNotifyChannelUIImpl::InfoBar to AppNotifyChannelUIInfoBarDelegate for consistency with ot… (Closed)

Created:
7 years, 11 months ago by Peter Kasting

Modified:
7 years, 11 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Rename AppNotifyChannelUIImpl::InfoBar to AppNotifyChannelUIInfoBarDelegate for consistency with other infobars, and because the style guide pushes people away from member classes when not necessary. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175246

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -21 lines)			Patch
	M	chrome/browser/extensions/app_notify_channel_ui_impl.h	View		1 chunk	+1 line, -7 lines	0 comments	Download
	M	chrome/browser/extensions/app_notify_channel_ui_impl.cc	View	1	5 chunks	+19 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages