Issue 11740027: Rename unsubscribe to cancel.

Issue 11740027: Rename unsubscribe to cancel. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
Bob Nystrom, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/experimental/lib_v2/dart

Visibility:
Public.

More Reviews

Description

Rename unsubscribe to cancel. Committed: https://code.google.com/p/dart/source/detail?r=16642

Patch Set 2 : Fix some comments. #

Patch Set 3 : Fix error message. #

Total comments: 6

Patch Set 4 : Address comments. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -65 lines)			Patch
M	sdk/lib/async/merge_stream.dart	View	2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	1 2 3	18 chunks	+30 lines, -30 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View	1 2 3	9 chunks	+24 lines, -24 lines	0 comments	Download
M	sdk/lib/async/stream_pipe.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/async/stream_controller_async_test.dart	View	2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View	2 3	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM & STV! https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream.dart#newcode198 sdk/lib/async/stream.dart:198: subscription = listen( Not your code ...

7 years, 11 months ago (2013-01-04 08:17:55 UTC) #3

floitsch

7 years, 11 months ago (2013-01-04 15:51:36 UTC) #4

https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream.dart#...
sdk/lib/async/stream.dart:198: subscription = listen(
On 2013/01/04 08:17:55, Lasse Reichstein Nielsen wrote:
> Not your code (probably mine), but ...
> This uses "listen" and the above cases uses "this.listen". Should it be
> consistent?
Added this. here at the other use-sites.

https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream_impl....
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream_impl....
sdk/lib/async/stream_impl.dart:441: * Handle an unsubscription requested from a
[_StreamSubscriptionImpl].
On 2013/01/04 08:17:55, Lasse Reichstein Nielsen wrote:
> a cancel request.

Done.

https://codereview.chromium.org/11740027/diff/4001/sdk/lib/async/stream_impl....
sdk/lib/async/stream_impl.dart:445: * If an event is currently firing, the
subscription is delayed
On 2013/01/04 08:17:55, Lasse Reichstein Nielsen wrote:
> subscription (sic) -> cancel.
> Perhaps also -> "... until after the subscriber has received the event". This
is
> actually what happens now.

Done.

Expand Messages | Collapse Messages