[telemetry] Removing globals from webpagereplay.py.

[telemetry] Removing globals from webpagereplay.py.

This is another clean-up patch for https://codereview.chromium.org/11348217/#msg10.
These globals have been complicating things, so it should be cleaner to have them
explicitly passed in when needed.

BUG=157459
TBR=kkania

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175149

[hartmanng, 2013-01-03 16:13:22]

Please take a look.

Is there anyone in particular who would be a good owner for the
chrome/test/functional/ side?

[tonyg, 2013-01-03 19:00:12]

lgtm

dennisjeffrey or nirnimesh would be good reviewers for chrome/test/functional.

https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
File chrome/test/functional/devtools_test_base.py (right):

https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
chrome/test/functional/devtools_test_base.py:49:
webpagereplay.GetChromeFlags(self.WEBPAGEREPLAY_HOST,
Please indent this

[hartmanng, 2013-01-03 19:08:50]

Thanks Tony!

dennis_jeffrey, please take a look.

https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
File chrome/test/functional/devtools_test_base.py (right):

https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
chrome/test/functional/devtools_test_base.py:49:
webpagereplay.GetChromeFlags(self.WEBPAGEREPLAY_HOST,
On 2013/01/03 19:00:12, tonyg wrote:
> Please indent this

Done.

[dyu1, 2013-01-03 19:14:29]

dennis is OOO and wont be back until mid Jan. Nir is no longer on the team. Your
best bet for a quick review would be kkania who'll be back next week. 

On 2013/01/03 19:08:50, hartmanng wrote:
> Thanks Tony!
> 
> dennis_jeffrey, please take a look.
> 
>
https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
> File chrome/test/functional/devtools_test_base.py (right):
> 
>
https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
> chrome/test/functional/devtools_test_base.py:49:
> webpagereplay.GetChromeFlags(self.WEBPAGEREPLAY_HOST,
> On 2013/01/03 19:00:12, tonyg wrote:
> > Please indent this
> 
> Done.

[hartmanng, 2013-01-03 19:17:18]

On 2013/01/03 19:14:29, dyu1 wrote:
> dennis is OOO and wont be back until mid Jan. Nir is no longer on the team.
Your
> best bet for a quick review would be kkania who'll be back next week. 
> 
> On 2013/01/03 19:08:50, hartmanng wrote:
> > Thanks Tony!
> > 
> > dennis_jeffrey, please take a look.
> > 
> >
>
https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
> > File chrome/test/functional/devtools_test_base.py (right):
> > 
> >
>
https://codereview.chromium.org/11740020/diff/4001/chrome/test/functional/dev...
> > chrome/test/functional/devtools_test_base.py:49:
> > webpagereplay.GetChromeFlags(self.WEBPAGEREPLAY_HOST,
> > On 2013/01/03 19:00:12, tonyg wrote:
> > > Please indent this
> > 
> > Done.


Thanks for the info, dyu.

kkania, please take a look when you get in.

[nduca, 2013-01-03 23:42:24]

Given the triviality of the change, I think you could TBR=kkania

[commit-bot: I haz the power, 2013-01-04 15:06:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11740020/1010

[commit-bot: I haz the power, 2013-01-04 17:54:55]

Change committed as 175149

[tonyg, 2013-01-04 19:34:53]

On 2013/01/04 17:54:55, I haz the power (commit-bot) wrote:
> Change committed as 175149

It looks like this broke the netsim test:
http://build.chromium.org/p/chromium.perf/builders/Mac10.6%20Perf%283%29/buil...

I'll put together a fix