ui/views/controls/menu/submenu_view.cc - Issue 11740006: views: Mark a tap-down as handled only if scrolling was actually stopped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/submenu_view.cc

Issue 11740006: views: Mark a tap-down as handled only if scrolling was actually stopped. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/submenu_view.cc

diff --git a/ui/views/controls/menu/submenu_view.cc b/ui/views/controls/menu/submenu_view.cc

index ef49b79dc3b4f5ebaf4d7abed2bd37c98d36aeca..380f28aeb2cb3eac9052a550ee48f6ebc5d414b2 100644

--- a/ui/views/controls/menu/submenu_view.cc

+++ b/ui/views/controls/menu/submenu_view.cc

@@ -281,7 +281,10 @@ void SubmenuView::OnGestureEvent(ui::GestureEvent* event) {

break;

case ui::ET_GESTURE_TAP_DOWN:

case ui::ET_SCROLL_FLING_CANCEL:

- scroll_animator_->Stop();

+ if (scroll_animator_->is_scrolling())

+ scroll_animator_->Stop();

+ else

+ handled = false;

break;

default:

handled = false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »