getTopDevice is deprecated

getTopDevice is deprecated

BUG=499001
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197146

[reed1, 2015-06-10 19:39:59]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-10 19:40:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173973003/1

[reed1, 2015-06-10 21:33:35]

reed@google.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[f(malita), 2015-06-10 22:14:21]

https://codereview.chromium.org/1173973003/diff/1/Source/platform/graphics/Ca...
File Source/platform/graphics/Canvas2DLayerBridge.cpp (right):

https://codereview.chromium.org/1173973003/diff/1/Source/platform/graphics/Ca...
Source/platform/graphics/Canvas2DLayerBridge.cpp:523: GrRenderTarget*
renderTarget = m_canvas->getDevice()->accessRenderTarget();
Are these really interchangeable?

IIUC getDevice() returns the root device while getTopDevice returns the top-most
device.  It seems these would be backed by different pixels/textures, no?

[commit-bot: I haz the power, 2015-06-10 22:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 22:44:16]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-06-11 13:12:08]

I can't tell that the callers actually need the top, and that is *more*
deprecated that getDevice (if that's possible). As with the bitlocker cl, do we
have tests that should tell us if this change is problematic?

[reed1, 2015-06-11 13:13:53]

Frankly, the important goal is to wean ImageBuffer off of bitmaps entirely, and
have it return images. This CL was just a baby step in that direction.

[f(malita), 2015-06-11 13:20:08]

fmalita@chromium.org changed reviewers:
+ junov@chromium.org

[f(malita), 2015-06-11 13:21:05]

On 2015/06/11 13:12:08, reed1 wrote:
> I can't tell that the callers actually need the top, and that is *more*
> deprecated that getDevice (if that's possible). As with the bitlocker cl, do
we
> have tests that should tell us if this change is problematic?

+Justin

[Justin Novosad, 2015-06-12 16:11:48]

lgtm

https://codereview.chromium.org/1173973003/diff/1/Source/platform/graphics/Ca...
File Source/platform/graphics/Canvas2DLayerBridge.cpp (right):

https://codereview.chromium.org/1173973003/diff/1/Source/platform/graphics/Ca...
Source/platform/graphics/Canvas2DLayerBridge.cpp:523: GrRenderTarget*
renderTarget = m_canvas->getDevice()->accessRenderTarget();
On 2015/06/10 22:14:21, f(malita) wrote:
> Are these really interchangeable?
> 
> IIUC getDevice() returns the root device while getTopDevice returns the
top-most
> device.  It seems these would be backed by different pixels/textures, no?

2D canvas never uses saveLayer, So I think this is fine.

[reed1, 2015-06-15 20:24:29]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-06-15 20:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173973003/1

[commit-bot: I haz the power, 2015-06-15 23:42:27]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197146