Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1173973002: X87: [strong] Refactor ObjectStrength into a replacement for strong boolean args (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [strong] Refactor ObjectStrength into a replacement for strong boolean args port dd8544495109804c632bfbcefc3c5c701e0a8c43 (r28839) original commit message: Boolean "is_strong" parameters have begun to proliferate across areas where strong mode semantics are different. This CL repurposes the existing ObjectStrength enum as a replacement for them. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/7e59d2603fc12fac615f3ae2d5197a52191ee99d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x87/lithium-x87.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-11 08:44:05 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-11 09:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173973002/1
5 years, 6 months ago (2015-06-11 09:02:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1223) v8_linux64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 6 months ago (2015-06-11 09:36:47 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e59d2603fc12fac615f3ae2d5197a52191ee99d Cr-Commit-Position: refs/heads/master@{#28952}
5 years, 6 months ago (2015-06-11 15:57:24 UTC) #8
chunyang.dai
5 years, 6 months ago (2015-06-11 15:57:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e59d2603fc12fac615f3ae2d5197a52191ee99d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698