Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 1173943002: Service Worker: Detach the controller when falling back to network on failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
index 2d709d04f91ee4ff2e8f4e0f8c194f21f6a2d59f..302fb034a8839bc8f3113297cbd607c7bea9960a 100644
--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
@@ -168,9 +168,9 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {
helper_->context()->AsWeakPtr(),
nullptr));
provider_host->SetDocumentUrl(GURL("http://example.com/"));
+ registration_->SetActiveVersion(version_);
provider_host->AssociateRegistration(registration_.get(),
false /* notify_controllerchange */);
- registration_->SetActiveVersion(version_);
ChromeBlobStorageContext* chrome_blob_storage_context =
ChromeBlobStorageContext::GetFor(browser_context_.get());
@@ -640,6 +640,10 @@ TEST_F(ServiceWorkerURLRequestJobTest, FailFetchDispatch) {
EXPECT_EQ(200, request_->GetResponseCode());
EXPECT_EQ("PASS", url_request_delegate_.response_data());
EXPECT_FALSE(HasInflightRequests());
+ ServiceWorkerProviderHost* host =
+ helper_->context()->GetProviderHost(kProcessID, kProviderID);
+ ASSERT_TRUE(host);
+ EXPECT_EQ(host->controlling_version(), nullptr);
}
// TODO(horo): Remove this test when crbug.com/485900 is fixed.
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698