Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1173933005: X87: Refactor lexical home object binding. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Refactor lexical home object binding. port 345fa142a9fca4b468417350ac26f61101d626e8 (r28802). port of r28769 overwrite some of r28802 so we port them again. original commit message: Before this we had 3 super related lexical bindings that got injected into method bodies: .home_object, .this_function, and new.target. With this change we get rid of the .home_object one in favor of using .this_function[home_object_symbol] which allows some simplifications throughout the code base. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/9afacc320f3f047a187c21e5387d37029bb1e487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M src/x87/full-codegen-x87.cc View 11 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-11 08:42:25 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-11 09:00:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173933005/1
5 years, 6 months ago (2015-06-11 09:01:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1220)
5 years, 6 months ago (2015-06-11 09:29:03 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9afacc320f3f047a187c21e5387d37029bb1e487 Cr-Commit-Position: refs/heads/master@{#28949}
5 years, 6 months ago (2015-06-11 15:50:57 UTC) #8
chunyang.dai
5 years, 6 months ago (2015-06-11 15:51:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9afacc320f3f047a187c21e5387d37029bb1e487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698