Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8842)

Unified Diff: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

Issue 1173933003: Disable BrowserActionsBarBrowserTest.BrowserActionPopupTest on Mac ASan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
diff --git a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
index 4824b5a2f872661b88f1c9a23f18be81ca4b7d91..01b3dd3e01e36d0748d3ee29e2efcf8a616ba976 100644
--- a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
+++ b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
@@ -335,7 +335,14 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarRedesignBrowserTest,
EXPECT_FALSE(browser_actions_bar()->OverflowedActionButtonWantsToRun());
}
-IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, BrowserActionPopupTest) {
+// Flaky on Mac ASan 64 bot. See http://crbug.com/498665.
+#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
+#define MAYBE_BrowserActionPopupTest DISABLED_BrowserActionPopupTest
+#else
+#define MAYBE_BrowserActionPopupTest BrowserActionPopupTest
+#endif
+IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest,
+ MAYBE_BrowserActionPopupTest) {
// Load up two extensions that have browser action popups.
base::FilePath data_dir =
test_data_dir_.AppendASCII("api_test").AppendASCII("browser_action");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698