Issue 117393002: Fix handling of aggregate times in TimerData::getResult

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117393002: Fix handling of aggregate times in TimerData::getResult (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
bsalomon, benchen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Prior to this CL, if one handed an aggregate time to the TimerData class it wouldn't be normalized by the number of iterations per timing when "perIter" results were requested.

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	bench/TimerData.cpp	View		1 chunk	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

https://codereview.chromium.org/117393002/diff/1/bench/TimerData.cpp File bench/TimerData.cpp (right): https://codereview.chromium.org/117393002/diff/1/bench/TimerData.cpp#newcode75 bench/TimerData.cpp:75: if (kPerIter_Result == result) { This is modeled on ...

7 years ago (2013-12-17 16:20:53 UTC) #1

Message was sent while issue was closed.

committed as r12709

Expand Messages | Collapse Messages