LayoutTests/fast/block/basic/fieldset-with-legend-right-margin.html - Issue 1173853005: LayoutFieldSet::computePreferredLogicalWidths uses marginLeft for marginRight by mistake

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/basic/fieldset-with-legend-right-margin.html

Issue 1173853005: LayoutFieldSet::computePreferredLogicalWidths uses marginLeft for marginRight by mistake Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding layout Test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <style>
	esprehn 2015/07/13 06:02:42 Add <!DOCTYPE html> Add <!DOCTYPE html>
	2 legend { height: 10px; border: 1px solid blue; }

	3 fieldset { margin-bottom: 10px;border: 2px solid green; }

	4 div.rel { position: relative; height: 100px;border:2px solid red; }
	esprehn 2015/07/13 06:02:42 missing space after ; in a couple places missing space after ; in a couple places
	5 </style>

	6 <script src="../../../resources/check-layout.js"></script>

	7 <body onload="checkLayout('fieldset');">

	8 <div class="rel" style="width: 500px;">

	9 <fieldset data-expected-margin-right="10" style="position: absolute;marg in-left:20px;margin-right:10px;">
	a.suchit 2015/07/13 12:59:09 we are correcting the legend margin right so data- we are correcting the legend margin right so data-expected-margin-right should be set for legend.
	10 <legend style="width: 150px;margin-left:10px;margin-right:20px"></le gend>

	11 <h1 style="background-color:green;margin:5px">HEADING 1</h1>

	12 </fieldset>

	13 </div>

	14 <div class="rel" style="width: 500px;">

	15 <fieldset data-expected-margin-right="20" style="position: absolute;marg in-left:40px;margin-right:20px;">

	16 <legend style="width: 150px;margin-left:10px;margin-right:20px"></le gend>

	17 <h1 style="background-color:green;margin:5px">HEADING 1</h1>

	18 </fieldset>

	19 </div>

	20 <div class="rel" style="width: 500px;margin-left :20px;">

	21 <fieldset data-expected-margin-right="-20" style="position: absolute;mar gin-left:-20px;margin-right:-20px;">

	22 <legend style="width: 150px;margin-left:10px;margin-right:20px"></le gend>

	23 <h1 style="background-color:green;margin:5px">HEADING 1</h1>

	24 </fieldset>

	25 </div>

	26 <div class="rel" style="width: 500px;">

	27 <fieldset data-expected-margin-right="-10" style="position: absolute;wid th:500px;margin-left:20px;margin-right:-10px;">

	28 <legend style="width: 150px;margin-left:10px;margin-right:20px"></le gend>

	29 <h1 style="background-color:green;margin:5px">HEADING 1</h1>

	30 </fieldset>

	31 </div>

	32 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/block/basic/fieldset-with-legend-right-margin-expected.txt » ('j') | no next file with comments »