Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1173813002: Small valgrind suppression tweak for statically linked ffmpeg (Closed)

Created:
5 years, 6 months ago by chcunningham
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang, DaleCurtis
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small valgrind suppression tweak for statically linked ffmpeg BUG=441333 The stack is slightly different now that we're statically linking. { Memcheck:Uninitialized fun:av_packet_unpack_dictionary fun:add_metadata_from_side_data fun:avcodec_decode_video2 fun:avcodec_decode_video2 <=== THIS REPEATED LINE IS GONE NOW fun:_ZN5media18FFmpegVideoDecoder12FFmpegDecodeERK13scoped_refptrINS_13DecoderBufferEEPb ... } Example log: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/46166/steps/memory%20test%3A%20media/logs/202EB30501710F5D Committed: https://crrev.com/5c06be0db44b0b6dc01d272e37d798218659b7c0 Cr-Commit-Position: refs/heads/master@{#333610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-09 22:53:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173813002/1
5 years, 6 months ago (2015-06-09 23:03:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 23:48:04 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 23:49:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c06be0db44b0b6dc01d272e37d798218659b7c0
Cr-Commit-Position: refs/heads/master@{#333610}

Powered by Google App Engine
This is Rietveld 408576698