[test] Clobber unclean test262-es6 checkouts.

[test] Clobber unclean test262-es6 checkouts.

Committed: https://crrev.com/8f4cd90e8f07cd266f73ad6a3b4a020690676e40
Cr-Commit-Position: refs/heads/master@{#28894}

[Michael Achenbach, 2015-06-10 07:56:13]

machenbach@chromium.org changed reviewers:
+ arv@chromium.org, jkummerow@chromium.org

[Michael Achenbach, 2015-06-10 07:56:50]

PTAL. This should also be ported to test262, but I wanna see the results first.

[Michael Achenbach, 2015-06-10 07:56:55]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-10 07:57:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173753004/1

[Jakob Kummerow, 2015-06-10 07:58:21]

lgtm

[commit-bot: I haz the power, 2015-06-10 08:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 08:25:39]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2015-06-10 08:30:12]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-06-10 08:30:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173753004/1

[commit-bot: I haz the power, 2015-06-10 08:31:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-10 08:31:40]

Patchset 1 (id:??) landed as
https://crrev.com/8f4cd90e8f07cd266f73ad6a3b4a020690676e40
Cr-Commit-Position: refs/heads/master@{#28894}

[arv (Not doing code reviews), 2015-06-10 14:24:33]

I think the underlying problem is here:

https://github.com/tc39/test262/issues/295

The "filenames" in the includes directive ended up containing an \r which
explains why the files could not be found

[Michael Achenbach, 2015-06-10 17:00:13]

On 2015/06/10 14:24:33, arv wrote:
> I think the underlying problem is here:
> 
> https://github.com/tc39/test262/issues/295
> 
> The "filenames" in the includes directive ended up containing an \r which
> explains why the files could not be found

Yea, that sounds like it. And the flakiness can maybe be explained with the
tester slaves changing between the runs. There might be some differences from
bot to bot how to handle this. This CL here, however, is still useful as we
otherwise aren't even able to cleanly revert a test262 upgrade.

Would we need an upstream fix for this?

[arv (Not doing code reviews), 2015-06-10 17:04:57]

On 2015/06/10 17:00:13, Michael Achenbach wrote:
> On 2015/06/10 14:24:33, arv wrote:
> > I think the underlying problem is here:
> > 
> > https://github.com/tc39/test262/issues/295
> > 
> > The "filenames" in the includes directive ended up containing an \r which
> > explains why the files could not be found
> 
> Yea, that sounds like it. And the flakiness can maybe be explained with the
> tester slaves changing between the runs. There might be some differences from
> bot to bot how to handle this. This CL here, however, is still useful as we
> otherwise aren't even able to cleanly revert a test262 upgrade.

There is more to it. Some bots have a yaml python package but not all do. If
they don't we use something called monkeyYaml which is part of the test262
harness. I've run into issues before where these two yaml implementations
diverged and caused some bots to pass and some to fail.

> Would we need an upstream fix for this?

I don't think this applies to the upstream test harness.