Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 117373002: Don't add -lrt when linking ASan/TSan/MSan binaries. (Closed)

Created:
7 years ago by Alexander Potapenko
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Don't add -lrt when linking ASan/TSan/MSan binaries. This is now done by the Clang driver. BUG=234010 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241298

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -6 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
TBR
7 years ago (2013-12-17 16:08:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/117373002/1
7 years ago (2013-12-17 16:08:26 UTC) #2
Alexander Potapenko
Committed patchset #1 manually as r241298 (presubmit successful).
7 years ago (2013-12-17 16:08:55 UTC) #3
Alexander Potapenko
On 2013/12/17 16:08:55, Alexander Potapenko wrote: > Committed patchset #1 manually as r241298 (presubmit successful). ...
7 years ago (2013-12-17 16:09:07 UTC) #4
Nico
https://codereview.chromium.org/117373002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/117373002/diff/1/build/common.gypi#newcode3401 build/common.gypi:3401: '-Wl,--as-needed', Can this be removed now too? Should http://llvm.org/bugs/show_bug.cgi?id=15823 ...
6 years, 6 months ago (2014-06-17 20:48:09 UTC) #5
Nico
6 years, 6 months ago (2014-06-18 18:30:50 UTC) #6
On Tue, Jun 17, 2014 at 1:48 PM, <thakis@chromium.org> wrote:

>
> https://codereview.chromium.org/117373002/diff/1/build/common.gypi
> File build/common.gypi (right):
>
> https://codereview.chromium.org/117373002/diff/1/build/
> common.gypi#newcode3401
> build/common.gypi:3401: '-Wl,--as-needed',
> Can this be removed now too? Should
> http://llvm.org/bugs/show_bug.cgi?id=15823 be marked as fixed?
>

glider: ^


>
> https://codereview.chromium.org/117373002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698