Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1173713002: Fix install-chroot.sh for recent versions of ubuntu (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix install-chroot.sh for recent versions of ubuntu Recent version of ubuntu such as trusty and saucy and have a newer version of schroot. The change teaches install-chroot.sh about the differences. Also, remove --no-lib32 argument to install-build-deps which no longer exists (means this script has been broken for quite a while now). TEST=install precise32bit chroot and build chrome within it BUG=410101 Committed: https://crrev.com/fdfaf8fa0c1879ff9557172b7f433747fa7355a9 Cr-Commit-Position: refs/heads/master@{#336594}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -26 lines) Patch
M build/install-chroot.sh View 1 5 chunks +56 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam Clegg
5 years, 6 months ago (2015-06-09 19:06:09 UTC) #2
Dirk Pranke
rubber-stamp lgtm w/ mmoss' approval.
5 years, 6 months ago (2015-06-09 19:07:30 UTC) #3
Michael Moss
lgtm
5 years, 6 months ago (2015-06-09 19:43:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173713002/20001
5 years, 5 months ago (2015-06-29 18:06:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-29 18:18:28 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 18:20:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdfaf8fa0c1879ff9557172b7f433747fa7355a9
Cr-Commit-Position: refs/heads/master@{#336594}

Powered by Google App Engine
This is Rietveld 408576698